Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: latestRequestReceivedAt #12270

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

atsu1125
Copy link
Contributor

@atsu1125 atsu1125 commented Nov 6, 2023

What

latestRequestReceivedAtが正しく表示されるようにする
Screenshot 2023-11-06 at 20 31 10

Why

Fix: #12269

Additional info (optional)

test success on
Misskey: 2023.11.0

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@atsu1125 atsu1125 marked this pull request as ready for review November 6, 2023 11:39
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (828749b) 78.82% compared to head (9b9a07c) 78.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12270      +/-   ##
===========================================
- Coverage    78.82%   78.71%   -0.12%     
===========================================
  Files          944      176     -768     
  Lines       101894    23316   -78578     
  Branches      8233      493    -7740     
===========================================
- Hits         80323    18354   -61969     
+ Misses       21571     4962   -16609     

see 768 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -61391,6 +61391,12 @@
             "optional": false,
             "nullable": true,
             "format": "date-time"
+          },
+          "latestRequestReceivedAt": {
+            "type": "string",
+            "optional": false,
+            "nullable": true,
+            "format": "date-time"
           }
         },
         "required": [
@@ -61415,7 +61421,8 @@
           "faviconUrl",
           "themeColor",
           "isSilenced",
-          "infoUpdatedAt"
+          "infoUpdatedAt",
+          "latestRequestReceivedAt"
         ]
       },
       "GalleryPost": {

Get diff files from Workflow Page

@syuilo syuilo merged commit 50430e3 into misskey-dev:develop Nov 11, 2023
17 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 11, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latestRequestReceivedAt 直近のリクエスト受信 が N/A になる
2 participants